From 69213d2ea4c23e44b26e58adc2e7c1b7d9351d62 Mon Sep 17 00:00:00 2001 From: Blake Erickson Date: Tue, 3 Dec 2019 00:37:01 -0700 Subject: [PATCH] FIX: 500 error for missing badge grouping (#8446) If a badge grouping happens to have been deleted a 500 error will be thrown when looking a user's badges. This fix allows the badge page to still be shown without any errors. The badge with the missing badge grouping is still displayed. I'll follow up with a separate pr/commit that will ensure if a badge grouping is deleted, all badges with that badge_grouping_id will also be updated. --- app/serializers/basic_user_badge_serializer.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/serializers/basic_user_badge_serializer.rb b/app/serializers/basic_user_badge_serializer.rb index 510f23b5e65..dd3880e4239 100644 --- a/app/serializers/basic_user_badge_serializer.rb +++ b/app/serializers/basic_user_badge_serializer.rb @@ -10,6 +10,6 @@ class BasicUserBadgeSerializer < ApplicationSerializer end def grouping_position - object.badge.badge_grouping.position + object.badge&.badge_grouping&.position end end