DEV: Fix various rubocop lints (#24749)

These (21 + 3 from previous PRs) are soon to be enabled in rubocop-discourse:

Capybara/VisibilityMatcher
Lint/DeprecatedOpenSSLConstant
Lint/DisjunctiveAssignmentInConstructor
Lint/EmptyConditionalBody
Lint/EmptyEnsure
Lint/LiteralInInterpolation
Lint/NonLocalExitFromIterator
Lint/ParenthesesAsGroupedExpression
Lint/RedundantCopDisableDirective
Lint/RedundantRequireStatement
Lint/RedundantSafeNavigation
Lint/RedundantStringCoercion
Lint/RedundantWithIndex
Lint/RedundantWithObject
Lint/SafeNavigationChain
Lint/SafeNavigationConsistency
Lint/SelfAssignment
Lint/UnreachableCode
Lint/UselessMethodDefinition
Lint/Void

Previous PRs:
Lint/ShadowedArgument
Lint/DuplicateMethods
Lint/BooleanSymbol
RSpec/SpecFilePathSuffix
This commit is contained in:
Jarek Radosz
2023-12-06 23:25:00 +01:00
committed by GitHub
parent 47f298b2f4
commit 694b5f108b
129 changed files with 196 additions and 274 deletions
+5 -7
View File
@@ -3,15 +3,13 @@
RSpec.describe RejectionMailer do
describe "send_rejection" do
context "when sending rejection email" do
fab! (:user) {
Fabricate(:user)
}
let (:template_args) {
fab!(:user) { Fabricate(:user) }
let(:template_args) do
{ former_title: "Mail Subject", destination: user.email, site_name: SiteSetting.title }
}
let (:reject_mail) {
end
let(:reject_mail) do
RejectionMailer.send_rejection("email_reject_topic_not_found", user.email, template_args)
}
end
it "renders the senders email" do
expect(reject_mail.to).to eql([user.email])