From 698e7a17dd9a9a7d4d3f82668bbacf7c4b1ea313 Mon Sep 17 00:00:00 2001
From: Gary Pendergast <gary@pento.net>
Date: Wed, 15 Jan 2025 15:19:11 +1100
Subject: [PATCH] UX: Use DPageHeader on the Site Settings page (#30783)

Update the header of the admin Site Settings page to be more consistent with the rest of the admin UI.
---
 .../javascripts/admin/addon/templates/admin.hbs    |  2 +-
 .../admin/addon/templates/site-settings.hbs        | 14 ++++++++++++++
 config/locales/client.en.yml                       |  4 +++-
 3 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/app/assets/javascripts/admin/addon/templates/admin.hbs b/app/assets/javascripts/admin/addon/templates/admin.hbs
index 5a345cf607d..2c34a5fd8c6 100644
--- a/app/assets/javascripts/admin/addon/templates/admin.hbs
+++ b/app/assets/javascripts/admin/addon/templates/admin.hbs
@@ -11,7 +11,7 @@
           {{#if this.currentUser.admin}}
             <NavItem
               @route="adminSiteSettings"
-              @label="admin.site_settings.title"
+              @label="admin.site_settings.nav_title"
             />
           {{/if}}
           <NavItem @route="adminUsers" @label="admin.users.title" />
diff --git a/app/assets/javascripts/admin/addon/templates/site-settings.hbs b/app/assets/javascripts/admin/addon/templates/site-settings.hbs
index a8225709bf4..4b4b33d6b45 100644
--- a/app/assets/javascripts/admin/addon/templates/site-settings.hbs
+++ b/app/assets/javascripts/admin/addon/templates/site-settings.hbs
@@ -1,3 +1,17 @@
+<DPageHeader
+  @titleLabel={{i18n "admin.site_settings.title"}}
+  @descriptionLabel={{i18n "admin.site_settings.description"}}
+  @hideTabs={{true}}
+>
+  <:breadcrumbs>
+    <DBreadcrumbsItem @path="/admin" @label={{i18n "admin_title"}} />
+    <DBreadcrumbsItem
+      @path="/admin/site_settings"
+      @label={{i18n "admin.site_settings.title"}}
+    />
+  </:breadcrumbs>
+</DPageHeader>
+
 <AdminSiteSettingsFilterControls
   @initialFilter={{this.filter}}
   @onChangeFilter={{this.filterChanged}}
diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml
index 893b9b60e44..e6df269021a 100644
--- a/config/locales/client.en.yml
+++ b/config/locales/client.en.yml
@@ -7195,11 +7195,13 @@ en:
         unmask: "unmask input"
         not_found: "Settings could not be found"
       site_settings:
+        title: "Site Settings"
+        description: "Configure the settings for your Discourse site to customize its appearance, functionality, and user experience."
         emoji_list:
           invalid_input: "Emoji list should only contain valid emoji names, eg: hugs"
           add_emoji_button:
             label: "Add Emoji"
-        title: "Settings"
+        nav_title: "Settings"
         no_results: "No results found."
         more_site_setting_results:
           one: "There is more than %{count} result. Please refine your search or select a category."