FIX: don't suggest a username that's already taken, even if hub finds a match

This commit is contained in:
Neil Lalonde
2013-11-20 14:56:21 -05:00
parent 97cb9e1545
commit 69cc1dd689
2 changed files with 14 additions and 1 deletions
@@ -95,6 +95,14 @@ describe UsernameCheckerService do
DiscourseHub.stubs(:nickname_for_email).returns('vincent')
result.should == {suggestion: 'vincent'}
end
it 'match found for email, but username is taken' do
# This case can happen when you've already signed up on the site,
# or enforce_global_nicknames used to be disabled.
DiscourseHub.stubs(:nickname_for_email).returns('taken')
User.stubs(:username_available?).with('taken').returns(false)
result.should == {suggestion: nil}
end
end
context 'username is nil' do