IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

update matchers to improve test suite perf for upload specs (#24744)

Browse Source 
This change speeds up our upload specs by avoiding Capybara's default_max_wait_time.
This commit is contained in:
David Battersby 2023-12-06 18:02:55 +08:00 committed by GitHub
parent 8b46dc8bb5
commit 6dd4937b69
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/chat/spec/system/uploads_spec.rb
View File

@ -30,7 +30,7 @@ describe "Uploading files in chat messages", type: :system do
channel_page.send_message("upload testing") channel_page.send_message("upload testing")
expect(page).not_to have_css(".chat-composer-upload") expect(page).to have_no_css(".chat-composer-upload")
expect(channel_page.messages).to have_message( expect(channel_page.messages).to have_message(
text: "upload testing\n#{File.basename(file_path)}", text: "upload testing\n#{File.basename(file_path)}",
@ -95,7 +95,7 @@ describe "Uploading files in chat messages", type: :system do
expect(page).to have_css(".chat-composer-upload .preview .preview-img", count: 2) expect(page).to have_css(".chat-composer-upload .preview .preview-img", count: 2)
channel_page.send_message("upload testing") channel_page.send_message("upload testing")
expect(page).not_to have_css(".chat-composer-upload") expect(page).to have_no_css(".chat-composer-upload")
expect(channel_page.messages).to have_message( expect(channel_page.messages).to have_message(
text: "upload testing\n#{I18n.t("js.chat.uploaded_files", count: 2)}", text: "upload testing\n#{I18n.t("js.chat.uploaded_files", count: 2)}",
persisted: true, persisted: true,
@ -123,7 +123,7 @@ describe "Uploading files in chat messages", type: :system do
channel_page.send_message("upload testing") channel_page.send_message("upload testing")
expect(page).not_to have_css(".chat-composer-upload") expect(page).to have_no_css(".chat-composer-upload")
expect(channel_page.messages).to have_message( expect(channel_page.messages).to have_message(
text: "upload testing\n#{File.basename(file_path)}", text: "upload testing\n#{File.basename(file_path)}",
@ -178,7 +178,7 @@ describe "Uploading files in chat messages", type: :system do
channel_page.click_send_message channel_page.click_send_message
expect(page).not_to have_css(".chat-composer-upload") expect(page).to have_no_css(".chat-composer-upload")
expect(page).to have_css(".chat-img-upload", count: 2) expect(page).to have_css(".chat-img-upload", count: 2)
try_until_success(timeout: 5) { expect(message_2.reload.uploads.count).to eq(2) } try_until_success(timeout: 5) { expect(message_2.reload.uploads.count).to eq(2) }
@ -200,13 +200,13 @@ describe "Uploading files in chat messages", type: :system do
it "does not show the action button for uploading files in public channels" do it "does not show the action button for uploading files in public channels" do
chat.visit_channel(channel_1) chat.visit_channel(channel_1)
channel_page.open_action_menu channel_page.open_action_menu
expect(page).not_to have_css(".chat-upload-btn") expect(page).to have_no_css(".chat-upload-btn")
end end
it "does not show the action button for uploading files in direct message channels" do it "does not show the action button for uploading files in direct message channels" do
chat.visit_channel(direct_message_channel_1) chat.visit_channel(direct_message_channel_1)
channel_page.open_action_menu channel_page.open_action_menu
expect(page).not_to have_css(".chat-upload-btn") expect(page).to have_no_css(".chat-upload-btn")
end end
end end
end end