mirror of
https://github.com/discourse/discourse.git
synced 2026-08-11 05:25:16 -05:00
DEV: Allow fab! without block (#24314)
The most common thing that we do with fab! is:
fab!(:thing) { Fabricate(:thing) }
This commit adds a shorthand for this which is just simply:
fab!(:thing)
i.e. If you omit the block, then, by default, you'll get a `Fabricate`d object using the fabricator of the same name.
This commit is contained in:
+10
-10
@@ -1,7 +1,7 @@
|
||||
# frozen_string_literal: true
|
||||
|
||||
RSpec.describe Post do
|
||||
fab!(:coding_horror) { Fabricate(:coding_horror) }
|
||||
fab!(:coding_horror)
|
||||
|
||||
let(:upload_path) { Discourse.store.upload_path }
|
||||
|
||||
@@ -214,9 +214,9 @@ RSpec.describe Post do
|
||||
end
|
||||
|
||||
describe "flagging helpers" do
|
||||
fab!(:post) { Fabricate(:post) }
|
||||
fab!(:post)
|
||||
fab!(:user) { coding_horror }
|
||||
fab!(:admin) { Fabricate(:admin) }
|
||||
fab!(:admin)
|
||||
|
||||
it "is_flagged? is accurate" do
|
||||
PostActionCreator.off_topic(user, post)
|
||||
@@ -915,7 +915,7 @@ RSpec.describe Post do
|
||||
end
|
||||
|
||||
context "with a new reply" do
|
||||
fab!(:topic) { Fabricate(:topic) }
|
||||
fab!(:topic)
|
||||
let(:other_user) { coding_horror }
|
||||
let(:reply_text) { "[quote=\"Evil Trout, post:1\"]\nhello\n[/quote]\nHmmm!" }
|
||||
let!(:post) do
|
||||
@@ -1020,7 +1020,7 @@ RSpec.describe Post do
|
||||
end
|
||||
|
||||
describe "reply_ids" do
|
||||
fab!(:topic) { Fabricate(:topic) }
|
||||
fab!(:topic)
|
||||
let!(:p1) { Fabricate(:post, topic: topic, post_number: 1) }
|
||||
let!(:p2) { Fabricate(:post, topic: topic, post_number: 2, reply_to_post_number: 1) }
|
||||
let!(:p3) { Fabricate(:post, topic: topic, post_number: 3) }
|
||||
@@ -1395,7 +1395,7 @@ RSpec.describe Post do
|
||||
end
|
||||
|
||||
describe "#set_owner" do
|
||||
fab!(:post) { Fabricate(:post) }
|
||||
fab!(:post)
|
||||
|
||||
it "will change owner of a post correctly" do
|
||||
post.set_owner(coding_horror, Discourse.system_user)
|
||||
@@ -1462,7 +1462,7 @@ RSpec.describe Post do
|
||||
end
|
||||
|
||||
describe "#hide!" do
|
||||
fab!(:post) { Fabricate(:post) }
|
||||
fab!(:post)
|
||||
|
||||
after { Discourse.redis.flushdb }
|
||||
|
||||
@@ -1490,7 +1490,7 @@ RSpec.describe Post do
|
||||
end
|
||||
|
||||
describe "#unhide!" do
|
||||
fab!(:post) { Fabricate(:post) }
|
||||
fab!(:post)
|
||||
|
||||
before { SiteSetting.unique_posts_mins = 5 }
|
||||
|
||||
@@ -2090,8 +2090,8 @@ RSpec.describe Post do
|
||||
end
|
||||
|
||||
describe "#cannot_permanently_delete_reason" do
|
||||
fab!(:post) { Fabricate(:post) }
|
||||
fab!(:admin) { Fabricate(:admin) }
|
||||
fab!(:post)
|
||||
fab!(:admin)
|
||||
|
||||
before do
|
||||
freeze_time
|
||||
|
||||
Reference in New Issue
Block a user