DEV: Allow fab! without block (#24314)

The most common thing that we do with fab! is:

    fab!(:thing) { Fabricate(:thing) }

This commit adds a shorthand for this which is just simply:

    fab!(:thing)

i.e. If you omit the block, then, by default, you'll get a `Fabricate`d object using the fabricator of the same name.
This commit is contained in:
Daniel Waterworth
2023-11-09 16:47:59 -06:00
committed by GitHub
parent d91456fd53
commit 6e161d3e75
471 changed files with 1277 additions and 1273 deletions

View File

@@ -1,9 +1,9 @@
# frozen_string_literal: true
RSpec.describe Admin::ReportsController do
fab!(:admin) { Fabricate(:admin) }
fab!(:moderator) { Fabricate(:moderator) }
fab!(:user) { Fabricate(:user) }
fab!(:admin)
fab!(:moderator)
fab!(:user)
describe "#bulk" do
context "when logged in as an admin" do
@@ -169,7 +169,7 @@ RSpec.describe Admin::ReportsController do
end
describe "when report is scoped to a category" do
fab!(:category) { Fabricate(:category) }
fab!(:category)
fab!(:topic) { Fabricate(:topic, category: category) }
fab!(:other_topic) { Fabricate(:topic) }
@@ -186,9 +186,9 @@ RSpec.describe Admin::ReportsController do
end
describe "when report is scoped to a group" do
fab!(:user) { Fabricate(:user) }
fab!(:user)
fab!(:other_user) { Fabricate(:user) }
fab!(:group) { Fabricate(:group) }
fab!(:group)
it "should render the report as JSON" do
group.add(user)