mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
DEV: Allow fab! without block (#24314)
The most common thing that we do with fab! is:
fab!(:thing) { Fabricate(:thing) }
This commit adds a shorthand for this which is just simply:
fab!(:thing)
i.e. If you omit the block, then, by default, you'll get a `Fabricate`d object using the fabricator of the same name.
This commit is contained in:
committed by
GitHub
parent
d91456fd53
commit
6e161d3e75
@@ -4,7 +4,7 @@ RSpec.describe BasicGroupSerializer do
|
||||
subject(:serializer) { described_class.new(group, scope: guardian, root: false) }
|
||||
|
||||
let(:guardian) { Guardian.new }
|
||||
fab!(:group) { Fabricate(:group) }
|
||||
fab!(:group)
|
||||
|
||||
describe "#display_name" do
|
||||
describe "automatic group" do
|
||||
@@ -16,7 +16,7 @@ RSpec.describe BasicGroupSerializer do
|
||||
end
|
||||
|
||||
describe "normal group" do
|
||||
fab!(:group) { Fabricate(:group) }
|
||||
fab!(:group)
|
||||
|
||||
it "should not include the display name" do
|
||||
expect(serializer.display_name).to eq(nil)
|
||||
@@ -54,7 +54,7 @@ RSpec.describe BasicGroupSerializer do
|
||||
end
|
||||
|
||||
describe "for a group user" do
|
||||
fab!(:user) { Fabricate(:user) }
|
||||
fab!(:user)
|
||||
let(:guardian) { Guardian.new(user) }
|
||||
|
||||
before { group.add(user) }
|
||||
@@ -77,7 +77,7 @@ RSpec.describe BasicGroupSerializer do
|
||||
fab!(:group) { Fabricate(:group, members_visibility_level: Group.visibility_levels[:members]) }
|
||||
|
||||
describe "for a group user" do
|
||||
fab!(:user) { Fabricate(:user) }
|
||||
fab!(:user)
|
||||
let(:guardian) { Guardian.new(user) }
|
||||
|
||||
before { group.add(user) }
|
||||
|
||||
Reference in New Issue
Block a user