FIX: When admin changes an email for the user the user must confirm the change (#10830)

See https://meta.discourse.org/t/changing-a-users-email/164512 for additional context.

Previously when an admin user changed a user's email we assumed that they would need a password reset too because they likely did not have access to their account. This proved to be incorrect, as there are other reasons a user needs admin to change their email. This PR:

* Changes the admin change email for user flow so the user is sent an email to confirm the change
* We now record who the email change request was requested by
* If the requested by user is admin and not the user we note this in the email sent to the user
* We also make the confirm change email route open to anonymous users, so it can be clicked by the user even if they do not have access to their account. If there is a logged in user we make sure the confirmation matches the current user.
This commit is contained in:
Martin Brennan
2020-10-07 13:02:24 +10:00
committed by GitHub
parent 3303b7f9d0
commit 6e2be3e60b
14 changed files with 155 additions and 62 deletions

View File

@@ -0,0 +1,13 @@
# frozen_string_literal: true
class AddRequestedByToEmailChangeRequest < ActiveRecord::Migration[6.0]
def up
add_column :email_change_requests, :requested_by_user_id, :integer, null: true
DB.exec("CREATE INDEX IF NOT EXISTS idx_email_change_requests_on_requested_by ON email_change_requests(requested_by_user_id)")
end
def down
remove_column :email_change_requests, :requested_by_user_id
end
end