IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Re-enable hashtag system specs (#19396)

Browse Source 
I have tried running these multiple times locally and on CI with the exact same seed as a failing one and without that seed too, also with these individual specs split into their own PRs. Nothing is failing, so I don't really know what else I can do if there is no consistent reproduction, so re-enabling for now.
This commit is contained in:
Martin Brennan
2022-12-09 13:10:20 +10:00
committed by GitHub
parent 0c50bacbc0
commit 6e65e4a935
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
spec/system/hashtag_autocomplete_spec.rb
View File

@@ -32,13 +32,13 @@ describe "Using #hashtag autocompletion to search for and lookup categories and
) )
end end
xit "searches for categories and tags with # and prioritises categories in the results" do it "searches for categories and tags with # and prioritises categories in the results" do
visit_topic_and_initiate_autocomplete visit_topic_and_initiate_autocomplete
hashtag_results = page.all(".hashtag-autocomplete__link", count: 2) hashtag_results = page.all(".hashtag-autocomplete__link", count: 2)
expect(hashtag_results.map(&:text)).to eq(["Cool Category", "cooltag x 325"]) expect(hashtag_results.map(&:text)).to eq(["Cool Category", "cooltag x 325"])
end end
xit "begins showing results as soon as # is pressed based on categories and tags topic_count" do it "begins showing results as soon as # is pressed based on categories and tags topic_count" do
visit_topic_and_initiate_autocomplete(initiation_text: "#", expected_count: 5) visit_topic_and_initiate_autocomplete(initiation_text: "#", expected_count: 5)
hashtag_results = page.all(".hashtag-autocomplete__link") hashtag_results = page.all(".hashtag-autocomplete__link")
expect(hashtag_results.map(&:text)).to eq( expect(hashtag_results.map(&:text)).to eq(
@@ -52,7 +52,7 @@ describe "Using #hashtag autocompletion to search for and lookup categories and
) )
end end
xit "cooks the selected hashtag clientside with the correct url and icon" do it "cooks the selected hashtag clientside with the correct url and icon" do
visit_topic_and_initiate_autocomplete visit_topic_and_initiate_autocomplete
hashtag_results = page.all(".hashtag-autocomplete__link", count: 2) hashtag_results = page.all(".hashtag-autocomplete__link", count: 2)
hashtag_results[0].click hashtag_results[0].click
@@ -73,7 +73,7 @@ describe "Using #hashtag autocompletion to search for and lookup categories and
HTML HTML
end end
xit "cooks the hashtags for tag and category correctly serverside when the post is saved to the database" do it "cooks the hashtags for tag and category correctly serverside when the post is saved to the database" do
topic_page.visit_topic_and_open_composer(topic) topic_page.visit_topic_and_open_composer(topic)
expect(topic_page).to have_expanded_composer expect(topic_page).to have_expanded_composer
topic_page.type_in_composer("this is a #cool-cat category and a #cooltag tag") topic_page.type_in_composer("this is a #cool-cat category and a #cooltag tag")