From 6f0b9bb1c4d93bc4fd865c6f9920991ded846b7d Mon Sep 17 00:00:00 2001 From: Martin Brennan Date: Tue, 29 Nov 2022 10:56:17 +1000 Subject: [PATCH] FIX: Allow hashtag autocomplete at start of line (#19216) Back when we introduced hashtag autocomplete in c1dbf5c1c421f6e485c0552df0d280739e061270 we had to disallow triggering it using # at the start of the line because our old markdown engine rendered headers with `#abc`, but now our new engine does `# abc` so it is safe to allow hashtag autocompletion straight away. --- .../javascripts/discourse/app/lib/hashtag-autocomplete.js | 7 ------- 1 file changed, 7 deletions(-) diff --git a/app/assets/javascripts/discourse/app/lib/hashtag-autocomplete.js b/app/assets/javascripts/discourse/app/lib/hashtag-autocomplete.js index 786486b7708..5d11a50ccf4 100644 --- a/app/assets/javascripts/discourse/app/lib/hashtag-autocomplete.js +++ b/app/assets/javascripts/discourse/app/lib/hashtag-autocomplete.js @@ -50,11 +50,9 @@ export function setupHashtagAutocomplete( export function hashtagTriggerRule(textarea, opts) { const result = caretRowCol(textarea); const row = result.rowNum; - let col = result.colNum; let line = textarea.value.split("\n")[row - 1]; if (opts && opts.backSpace) { - col = col - 1; line = line.slice(0, line.length - 1); // Don't trigger autocomplete when backspacing into a `#category |` => `#category|` @@ -63,11 +61,6 @@ export function hashtagTriggerRule(textarea, opts) { } } - // Don't trigger autocomplete when ATX-style headers are used - if (col < 6 && line.slice(0, col) === "#".repeat(col)) { - return false; - } - if (inCodeBlock(textarea.value, caretPosition(textarea))) { return false; }