DEV: Bump @discourse/lint-configs and autofix (#29847)

In particular, this applies:

- new `discourse/no-implicit-this` template-lint rule
- `init`/`willDestroy` ordering enforcement
- `lines-between-class-members`
This commit is contained in:
David Taylor
2024-11-20 14:15:04 +00:00
committed by GitHub
parent 581fb97bfa
commit 6f7c581a80
62 changed files with 304 additions and 263 deletions

View File

@@ -28,6 +28,14 @@ export default class PollBreakdownChart extends Component {
this._optionToSlice = {};
}
willDestroy() {
super.willDestroy(...arguments);
if (this._chart) {
this._chart.destroy();
}
}
didInsertElement() {
super.didInsertElement(...arguments);
@@ -44,14 +52,6 @@ export default class PollBreakdownChart extends Component {
}
}
willDestroy() {
super.willDestroy(...arguments);
if (this._chart) {
this._chart.destroy();
}
}
@discourseComputed("optionColors", "index")
colorStyle(optionColors, index) {
return htmlSafe(`background: ${optionColors[index]};`);

View File

@@ -155,6 +155,7 @@ export default class PollInfoComponent extends Component {
this.publicTitle
);
}
<template>
<div class="poll-info">
<div class="poll-info_counts">

View File

@@ -104,6 +104,7 @@ export default class PollResultsPieComponent extends Component {
registerCanvasElement = modifier((element) => {
this.canvasElement = element;
});
get canvasId() {
return htmlSafe(`poll-results-chart-${this.args.id}`);
}
@@ -125,6 +126,7 @@ export default class PollResultsPieComponent extends Component {
// eslint-disable-next-line no-undef
this._chart = new Chart(el.getContext("2d"), config);
}
<template>
<div class="poll-results-chart">
<canvas

View File

@@ -72,6 +72,7 @@ export default class PollResultsStandardComponent extends Component {
get isMultiple() {
return this.args.pollType === "multiple";
}
<template>
<ul class="results">
{{#each this.orderedOptions key="voters" as |option|}}

View File

@@ -20,6 +20,7 @@ export default class TabsComponent extends Component {
? this.tabs[1]
: this.tabs[0];
}
get tabs() {
let tabs = [];