IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Managing sidebar custom sections not working on subfolder (#22773)

Browse Source 
Why this change?

We were verifying that a url for a section link in a custom sidebar
section is valid by passing the url string to `Router#recognize`.
If a `rootURL` has been set on the router, the url string that is passed
to `Router#recognize` has to start with the `rootURL`.

This commit fixes the problem by ensuring that `RouteInfoHelper` adds
the application subfolder path before calling `Router#recognize` on the
url string.
This commit is contained in:
Alan Guo Xiang Tan
2023-07-25 13:57:49 +08:00
committed by GitHub
parent fe1034e89c
commit 752bb29415
4 changed files with 35 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
spec/system/custom_sidebar_sections_spec.rb
View File

@@ -8,28 +8,38 @@ describe "Custom sidebar sections", type: :system do
before { user.user_option.update!(external_links_in_new_tab: true) }
it "allows the user to create custom section" do
visit("/latest")
shared_examples "creating custom sections" do |relative_root_url|
it "allows the user to create custom section" do
visit("#{relative_root_url}/latest")
expect(sidebar).to have_no_add_section_button
expect(sidebar).to have_no_add_section_button
sign_in user
visit("/latest")
sidebar.click_add_section_button
sign_in user
visit("#{relative_root_url}/latest")
sidebar.click_add_section_button
expect(section_modal).to be_visible
expect(section_modal).to have_disabled_save
expect(sidebar.custom_section_modal_title).to have_content("Add custom section")
expect(section_modal).to be_visible
expect(section_modal).to have_disabled_save
expect(sidebar.custom_section_modal_title).to have_content("Add custom section")
section_modal.fill_name("My section")
section_modal.fill_name("My section")
section_modal.fill_link("Sidebar Tags", "/tags")
expect(section_modal).to have_enabled_save
section_modal.fill_link("Sidebar Tags", "/tags")
expect(section_modal).to have_enabled_save
section_modal.save
section_modal.save
expect(sidebar).to have_section("My section")
expect(sidebar).to have_section_link("Sidebar Tags")
expect(sidebar).to have_section("My section")
expect(sidebar).to have_section_link("Sidebar Tags")
end
end
include_examples "creating custom sections"
context "when subfolder install" do
before { set_subfolder "/community" }
include_examples "creating custom sections", "/community"
end
it "allows the user to create custom section with /my link" do