mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
DEV: Drop unused image_url column from posts and topics (#9953)
This has been superseded by image_upload_id. The image_url value in API responses is now generated dynamically from the upload record.
This commit is contained in:
parent
d76ea9fa6b
commit
75b1298e99
@ -10,8 +10,10 @@ class Post < ActiveRecord::Base
|
|||||||
include HasCustomFields
|
include HasCustomFields
|
||||||
include LimitedEdit
|
include LimitedEdit
|
||||||
|
|
||||||
# TODO(2021-01-04): remove
|
self.ignored_columns = [
|
||||||
self.ignored_columns = ["avg_time"]
|
"avg_time", # TODO(2021-01-04): remove
|
||||||
|
"image_url" # TODO(2021-06-01): remove
|
||||||
|
]
|
||||||
|
|
||||||
cattr_accessor :plugin_permitted_create_params
|
cattr_accessor :plugin_permitted_create_params
|
||||||
self.plugin_permitted_create_params = {}
|
self.plugin_permitted_create_params = {}
|
||||||
@ -1145,7 +1147,6 @@ end
|
|||||||
# raw_email :text
|
# raw_email :text
|
||||||
# public_version :integer default(1), not null
|
# public_version :integer default(1), not null
|
||||||
# action_code :string
|
# action_code :string
|
||||||
# image_url :string
|
|
||||||
# locked_by_id :integer
|
# locked_by_id :integer
|
||||||
# image_upload_id :bigint
|
# image_upload_id :bigint
|
||||||
#
|
#
|
||||||
|
@ -10,8 +10,10 @@ class Topic < ActiveRecord::Base
|
|||||||
include LimitedEdit
|
include LimitedEdit
|
||||||
extend Forwardable
|
extend Forwardable
|
||||||
|
|
||||||
# TODO(2021-01-04): remove
|
self.ignored_columns = [
|
||||||
self.ignored_columns = ["avg_time"]
|
"avg_time", # TODO(2021-01-04): remove
|
||||||
|
"image_url" # TODO(2021-06-01): remove
|
||||||
|
]
|
||||||
|
|
||||||
def_delegator :featured_users, :user_ids, :featured_user_ids
|
def_delegator :featured_users, :user_ids, :featured_user_ids
|
||||||
def_delegator :featured_users, :choose, :feature_topic_users
|
def_delegator :featured_users, :choose, :feature_topic_users
|
||||||
@ -1663,7 +1665,6 @@ end
|
|||||||
# featured_user3_id :integer
|
# featured_user3_id :integer
|
||||||
# deleted_at :datetime
|
# deleted_at :datetime
|
||||||
# highest_post_number :integer default(0), not null
|
# highest_post_number :integer default(0), not null
|
||||||
# image_url :string
|
|
||||||
# like_count :integer default(0), not null
|
# like_count :integer default(0), not null
|
||||||
# incoming_link_count :integer default(0), not null
|
# incoming_link_count :integer default(0), not null
|
||||||
# category_id :integer
|
# category_id :integer
|
||||||
|
@ -0,0 +1,40 @@
|
|||||||
|
# frozen_string_literal: true
|
||||||
|
|
||||||
|
class RemoveImageUrlFromPostAndTopic < ActiveRecord::Migration[6.0]
|
||||||
|
disable_ddl_transaction!
|
||||||
|
|
||||||
|
def up
|
||||||
|
execute <<~SQL
|
||||||
|
ALTER TABLE topics DROP COLUMN IF EXISTS image_url
|
||||||
|
SQL
|
||||||
|
|
||||||
|
ActiveRecord::Base.transaction do
|
||||||
|
execute "DROP VIEW badge_posts"
|
||||||
|
|
||||||
|
execute <<~SQL
|
||||||
|
ALTER TABLE posts DROP COLUMN IF EXISTS image_url
|
||||||
|
SQL
|
||||||
|
|
||||||
|
# we must recreate this view every time we amend posts
|
||||||
|
# p.* is auto expanded and persisted into the view definition
|
||||||
|
# at create time
|
||||||
|
execute <<~SQL
|
||||||
|
CREATE VIEW badge_posts AS
|
||||||
|
SELECT p.*
|
||||||
|
FROM posts p
|
||||||
|
JOIN topics t ON t.id = p.topic_id
|
||||||
|
JOIN categories c ON c.id = t.category_id
|
||||||
|
WHERE c.allow_badges AND
|
||||||
|
p.deleted_at IS NULL AND
|
||||||
|
t.deleted_at IS NULL AND
|
||||||
|
NOT c.read_restricted AND
|
||||||
|
t.visible AND
|
||||||
|
p.post_type IN (1,2,3)
|
||||||
|
SQL
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
def down
|
||||||
|
# do nothing re-runnable
|
||||||
|
end
|
||||||
|
end
|
Loading…
Reference in New Issue
Block a user