IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: prevents double set in the same computation (#31348)

Browse Source 
The current code was doing:
- initial value for `showPreview`
- setting another default value in `_setupPreview`

The fix is to move all the computation in one initial step when
initializing the property.
This commit is contained in:
Joffrey JAFFEUX 2025-02-14 11:52:55 +01:00 committed by GitHub
parent 04531f1443
commit 7779cf1e90
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
app/assets/javascripts/discourse/app/services/composer.js
View File

@ -4,7 +4,7 @@ import { alias, and, or, reads } from "@ember/object/computed";
import { cancel, scheduleOnce } from "@ember/runloop"; import { cancel, scheduleOnce } from "@ember/runloop";
import Service, { service } from "@ember/service"; import Service, { service } from "@ember/service";
import { isEmpty } from "@ember/utils"; import { isEmpty } from "@ember/utils";
import { observes, on } from "@ember-decorators/object"; import { observes } from "@ember-decorators/object";
import $ from "jquery"; import $ from "jquery";
import { Promise } from "rsvp"; import { Promise } from "rsvp";
import DiscardDraftModal from "discourse/components/modal/discard-draft"; import DiscardDraftModal from "discourse/components/modal/discard-draft";
@ -107,7 +107,11 @@ export default class ComposerService extends Service {
@service siteSettings; @service siteSettings;
@service store; @service store;
@tracked showPreview = true; @tracked
showPreview = this.site.mobileView
? false
: (this.keyValueStore.get("composer.showPreview") || "true") === "true";
@tracked allowPreview = true; @tracked allowPreview = true;
checkedMessages = false; checkedMessages = false;
messageCount = null; messageCount = null;
@ -154,14 +158,6 @@ export default class ComposerService extends Service {
return NEW_PRIVATE_MESSAGE_KEY + "_" + new Date().getTime(); return NEW_PRIVATE_MESSAGE_KEY + "_" + new Date().getTime();
} }
@on("init")
_setupPreview() {
const val = this.site.mobileView
? false
: this.keyValueStore.get("composer.showPreview") || "true";
this.set("showPreview", val === "true");
}
@computed( @computed(
"model.loading", "model.loading",
"isUploading", "isUploading",