IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-29 20:24:05 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: isVisible is no longer allowed even if used properly

Browse Source 
This changes it to `shouldShow` instead.
This commit is contained in:
Robin Ward 2020-09-11 15:05:50 -04:00
parent 05831c2b42
commit 7887aaf587
3 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/assets/javascripts/discourse/app/components/private-message-glyph.js
View File

@ -5,4 +5,5 @@ export default Component.extend({
href: null, href: null,
title: null, title: null,
ariaLabel: null, ariaLabel: null,
shouldShow: null,
}); });

2
app/assets/javascripts/discourse/app/templates/components/private-message-glyph.hbs
View File

@ -1,4 +1,4 @@
{{#if isVisible}} {{#if shouldShow}}
{{#if href}} {{#if href}}
<a href={{href}} title={{i18n title}} aria-label={{i18n ariaLabel}}> <a href={{href}} title={{i18n title}} aria-label={{i18n ariaLabel}}>
<span class="private-message-glyph-wrapper"> <span class="private-message-glyph-wrapper">

6
app/assets/javascripts/discourse/app/templates/topic.hbs
View File

@ -17,7 +17,7 @@
{{#topic-title cancelled=(action "cancelEditingTopic") save=(action "finishedEditingTopic") model=model}} {{#topic-title cancelled=(action "cancelEditingTopic") save=(action "finishedEditingTopic") model=model}}
{{#if editingTopic}} {{#if editingTopic}}
<div class="edit-topic-title"> <div class="edit-topic-title">
{{private-message-glyph isVisible=model.isPrivateMessage}} {{private-message-glyph shouldShow=model.isPrivateMessage}}
{{text-field id="edit-title" value=buffered.title maxlength=siteSettings.max_topic_title_length autofocus="true"}} {{text-field id="edit-title" value=buffered.title maxlength=siteSettings.max_topic_title_length autofocus="true"}}
@ -61,13 +61,13 @@
{{#unless model.is_warning}} {{#unless model.is_warning}}
{{#if siteSettings.enable_personal_messages}} {{#if siteSettings.enable_personal_messages}}
{{private-message-glyph {{private-message-glyph
isVisible=model.isPrivateMessage shouldShow=model.isPrivateMessage
href=pmPath href=pmPath
title="topic_statuses.personal_message.title" title="topic_statuses.personal_message.title"
ariaLabel="user.messages.inbox" ariaLabel="user.messages.inbox"
}} }}
{{else}} {{else}}
{{private-message-glyph isVisible=model.isPrivateMessage}} {{private-message-glyph shouldShow=model.isPrivateMessage}}
{{/if}} {{/if}}
{{/unless}} {{/unless}}