From 78c5adc093e27b74d823c193f35902fc9a5977cb Mon Sep 17 00:00:00 2001 From: Sam Saffron Date: Tue, 8 Oct 2019 09:37:07 +1100 Subject: [PATCH] DEV: stop hardcoding ids in specs hardcoded ids are unreliable for running specs and lead to erratic failures --- spec/jobs/bulk_invite_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/jobs/bulk_invite_spec.rb b/spec/jobs/bulk_invite_spec.rb index 283fbee2e2d..f25bf7812e0 100644 --- a/spec/jobs/bulk_invite_spec.rb +++ b/spec/jobs/bulk_invite_spec.rb @@ -8,9 +8,9 @@ describe Jobs::BulkInvite do fab!(:admin) { Fabricate(:admin) } fab!(:group1) { Fabricate(:group, name: 'group1') } fab!(:group2) { Fabricate(:group, name: 'group2') } - fab!(:topic) { Fabricate(:topic, id: 999) } + fab!(:topic) { Fabricate(:topic) } let(:email) { "test@discourse.org" } - let(:invites) { [{ email: 'test2@discourse.org' }, { email: 'test@discourse.org', groups: 'GROUP1;group2', topic_id: 999 }] } + let(:invites) { [{ email: 'test2@discourse.org' }, { email: 'test@discourse.org', groups: 'GROUP1;group2', topic_id: topic.id }] } it 'raises an error when the invites array is missing' do expect { Jobs::BulkInvite.new.execute(current_user_id: user.id) }