IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: stop hardcoding ids in specs

Browse Source 
hardcoded ids are unreliable for running specs and lead to erratic failures
This commit is contained in:
Sam Saffron
2019-10-08 09:37:07 +11:00
parent afe7429e7d
commit 78c5adc093
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/jobs/bulk_invite_spec.rb
View File

@@ -8,9 +8,9 @@ describe Jobs::BulkInvite do
fab!(:admin) { Fabricate(:admin) } fab!(:admin) { Fabricate(:admin) }
fab!(:group1) { Fabricate(:group, name: 'group1') } fab!(:group1) { Fabricate(:group, name: 'group1') }
fab!(:group2) { Fabricate(:group, name: 'group2') } fab!(:group2) { Fabricate(:group, name: 'group2') }
fab!(:topic) { Fabricate(:topic, id: 999) } fab!(:topic) { Fabricate(:topic) }
let(:email) { "test@discourse.org" } let(:email) { "test@discourse.org" }
let(:invites) { [{ email: 'test2@discourse.org' }, { email: 'test@discourse.org', groups: 'GROUP1;group2', topic_id: 999 }] } let(:invites) { [{ email: 'test2@discourse.org' }, { email: 'test@discourse.org', groups: 'GROUP1;group2', topic_id: topic.id }] }
it 'raises an error when the invites array is missing' do it 'raises an error when the invites array is missing' do
expect { Jobs::BulkInvite.new.execute(current_user_id: user.id) } expect { Jobs::BulkInvite.new.execute(current_user_id: user.id) }