Username validation in signup and username change forms

spec/controllers/users_controller_spec.rb

@@ -483,6 +483,24 @@ describe UsersController do
         end
         it_should_behave_like 'when username is unavailable locally'
       end
+
+      context 'has invalid characters' do
+        before do
+          xhr :get, :check_username, username: 'bad username'
+        end
+
+        it 'should return success' do
+          response.should be_success
+        end
+
+        it 'should not return an available key' do
+          ::JSON.parse(response.body)['available'].should be_nil
+        end
+
+        it 'should return an error message' do
+          ::JSON.parse(response.body)['errors'].should_not be_empty
+        end
+      end
     end
 
     context 'when call_mothership is enabled' do

spec/models/user_spec.rb

@@ -394,6 +394,20 @@ describe User do
     end
   end
 
+  context '.username_valid?' do
+    it 'returns true when username is both valid and available' do
+      User.username_valid?('Available').should be_true
+    end
+
+    it 'returns true when the username is valid but not available' do
+      User.username_valid?(Fabricate(:user).username).should be_true
+    end
+
+    it 'returns false when the username is not valid' do
+      User.username_valid?('not valid.name').should be_false
+    end
+  end
+
   describe '.suggest_username' do
     it 'corrects weird characters' do
       User.suggest_username("Darth%^Vadar").should == "Darth_Vadar"