IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Switch default Ember version to 5 (#25203)

Browse Source 
https://meta.discourse.org/t/287211
This commit is contained in:
David Taylor
2024-01-10 12:12:36 +00:00
committed by GitHub
parent 627415eb21
commit 7a8cbf8422
8 changed files with 26 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
.github/workflows/ember-version-enforcement.yml vendored
View File

@@ -32,14 +32,14 @@ jobs:
node -e '
const version = require("ember-source/package.json").version;
console.log("Ember version is", version);
if(version.split(".")[0] !== "3"){
console.log(`Ember has unexpectedly been upgraded to version ${version}. If this is intentional, remove this github workflow.`);
if(version.split(".")[0] !== "5"){
console.log(`Ember has unexpectedly been downgraded to version ${version}. If this is intentional, remove this github workflow.`);
process.exit(1);
}
'
- name: Upgrade ember
- name: Downgrade ember
run: |
script/switch_ember_version 5
script/switch_ember_version 3
cd app/assets/javascripts/discourse
yarn install
- name: "Check upgraded version"
@@ -48,19 +48,19 @@ jobs:
node -e '
const version = require("ember-source/package.json").version;
console.log("Ember version is", version);
if(version.split(".")[0] !== "5"){
console.log(`Expected Ember 5, but found ${version}`);
if(version.split(".")[0] !== "3"){
console.log(`Expected Ember 3, but found ${version}`);
process.exit(1);
}
'
- name: "Revert ember upgrade"
- name: "Revert ember downgrade"
run: |
script/switch_ember_version 3
script/switch_ember_version 5
- name: "Ensure no diff"
run: |
if [ ! -z "$(git status --porcelain)" ]; then
echo "Working directory was not clean after upgrading/downgrading ember. Perhaps a lockfile is out-of-date. Run this command to re-sync:"
echo " script/regen_ember_5_lockfile"
echo " script/regen_ember_3_lockfile"
echo
echo "Current diff:"
echo "---------------------------------------------"

8
.github/workflows/ember-version-lockfiles.yml vendored
View File

@@ -20,11 +20,11 @@ jobs:
run: |
# Dependabot gets confused by the symlinks and dumps the updated lockfile in the root of the repo.
# Let's move it back to the correct location.
if [[ -f yarn-ember3.lock ]]; then
mv yarn-ember3.lock app/assets/javascripts/yarn-ember3.lock
if [[ -f yarn-ember5.lock ]]; then
mv yarn-ember5.lock app/assets/javascripts/yarn-ember5.lock
fi
- name: Update ember5 lockfile
run: script/regen_ember_5_lockfile
- name: Update ember3 lockfile
run: script/regen_ember_3_lockfile
- name: Push changes
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

10
.github/workflows/tests.yml vendored
View File

@@ -109,10 +109,6 @@ jobs:
path: ${{ steps.yarn-cache-dir.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}-cachev2
- name: Upgrade Ember
if: matrix.updated_ember == true
run: script/switch_ember_version 5
- name: Yarn install
run: yarn install --frozen-lockfile
@@ -369,9 +365,9 @@ jobs:
path: ${{ steps.yarn-cache-dir.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}-cachev2
- name: Upgrade Ember
if: matrix.updated_ember == true
run: script/switch_ember_version 5
- name: Downgrade Ember
if: matrix.updated_ember == false
run: script/switch_ember_version 3
- name: Yarn install
working-directory: ./app/assets/javascripts/discourse