From 7ac9a4d2ecac873f80e0ebb4862a3a37f078bcd0 Mon Sep 17 00:00:00 2001
From: Roman Rizzi <rizziromanalejandro@gmail.com>
Date: Mon, 18 Jan 2021 14:09:07 -0300
Subject: [PATCH] FIX: Allow users to opt-out of using the site's small logo as
 the system user avatar. (#11744)

---
 app/models/user.rb           | 5 ++++-
 config/locales/server.en.yml | 1 +
 config/site_settings.yml     | 3 +++
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/app/models/user.rb b/app/models/user.rb
index 07161e8ed01..0fa842fc8e2 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -868,7 +868,10 @@ class User < ActiveRecord::Base
   end
 
   def avatar_template
-    if id == Discourse::SYSTEM_USER_ID && SiteSetting.logo_small
+    use_small_logo = id == Discourse::SYSTEM_USER_ID &&
+      SiteSetting.logo_small && SiteSetting.use_site_small_logo_as_system_avatar
+
+    if use_small_logo
       UrlHelper.absolute(SiteSetting.logo_small.url)
     else
       self.class.avatar_template(username, uploaded_avatar_id)
diff --git a/config/locales/server.en.yml b/config/locales/server.en.yml
index 7dd6811e407..c4cd31e62c8 100644
--- a/config/locales/server.en.yml
+++ b/config/locales/server.en.yml
@@ -1776,6 +1776,7 @@ en:
 
     external_system_avatars_enabled: "Use external system avatars service."
     external_system_avatars_url: "URL of the external system avatars service. Allowed substitutions are {username} {first_letter} {color} {size}"
+    use_site_small_logo_as_system_avatar: "Use the site's small logo instead of the system user's avatar. Requires the logo to be present."
     restrict_letter_avatar_colors: "A list of 6-digit hexadecimal color values to be used for letter avatar background."
 
     selectable_avatars_enabled: "Force users to choose an avatar from the list."
diff --git a/config/site_settings.yml b/config/site_settings.yml
index c0bf6c81697..a040983cf4e 100644
--- a/config/site_settings.yml
+++ b/config/site_settings.yml
@@ -2083,6 +2083,9 @@ uncategorized:
     hidden: true
     default: true
 
+  use_site_small_logo_as_system_avatar:
+    default: true
+
   disable_system_edit_notifications: true
 
   notification_consolidation_threshold: