From 7b62f9ccd7f4e730c51db005e39410d96736356c Mon Sep 17 00:00:00 2001 From: Sam Date: Tue, 3 Sep 2013 19:11:55 +1000 Subject: [PATCH] more fixes for rails 4 --- lib/freedom_patches/ar_result.rb | 33 ++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 lib/freedom_patches/ar_result.rb diff --git a/lib/freedom_patches/ar_result.rb b/lib/freedom_patches/ar_result.rb new file mode 100644 index 00000000000..99e38fe8d79 --- /dev/null +++ b/lib/freedom_patches/ar_result.rb @@ -0,0 +1,33 @@ +#see: https://github.com/rails/rails/pull/12065 +if rails4? + module ActiveRecord + class Result + private + def hash_rows + @hash_rows ||= + begin + # We freeze the strings to prevent them getting duped when + # used as keys in ActiveRecord::Base's @attributes hash + columns = @columns.map { |c| c.dup.freeze } + @rows.map { |row| + # In the past we used Hash[columns.zip(row)] + # though elegant, the verbose way is much more efficient + # both time and memory wise cause it avoids a big array allocation + # this method is called a lot and needs to be micro optimised + hash = {} + + index = 0 + length = columns.length + + while index < length + hash[columns[index]] = row[index] + index += 1 + end + + hash + } + end + end + end + end +end