mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
UX: Style video elements, show descriptions (#10040)
It's a stop gap – ideally we would generate a thumbnail for uploaded videos. For now, a bit of intentionality in the style and a pinch of context should do.
This commit is contained in:
@@ -147,6 +147,7 @@ function videoHTML(token, opts) {
|
||||
const preloadType = opts.secureMedia ? "none" : "metadata";
|
||||
const dataOrigSrcAttr = origSrc !== null ? `data-orig-src="${origSrc}"` : "";
|
||||
return `<div class="video-container">
|
||||
<p class="video-description">${opts.alt}</p>
|
||||
<video width="100%" height="100%" preload="${preloadType}" controls>
|
||||
<source src="${src}" ${dataOrigSrcAttr}>
|
||||
<a href="${src}">${src}</a>
|
||||
@@ -176,7 +177,8 @@ function renderImageOrPlayableMedia(tokens, idx, options, env, slf) {
|
||||
// see https://github.com/markdown-it/markdown-it/blob/master/docs/architecture.md#renderer
|
||||
// handles |video and |audio alt transformations for image tags
|
||||
const mediaOpts = {
|
||||
secureMedia: options.discourse.limitedSiteSettings.secureMedia
|
||||
secureMedia: options.discourse.limitedSiteSettings.secureMedia,
|
||||
alt: split[0]
|
||||
};
|
||||
if (split[1] === "video") {
|
||||
return videoHTML(token, mediaOpts);
|
||||
|
||||
@@ -185,6 +185,7 @@ export const DEFAULT_LIST = [
|
||||
"span.excerpt",
|
||||
"div.excerpt",
|
||||
"div.video-container",
|
||||
"p.video-description",
|
||||
"span.hashtag",
|
||||
"span.mention",
|
||||
"strike",
|
||||
|
||||
Reference in New Issue
Block a user