IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

UX/PERF: Update readers count when a post from another user is read. Don't fetch the post data again just to update the count. (#8078)

Browse Source
This commit is contained in:
Roman Rizzi
2019-09-08 22:29:15 -03:00
committed by Sam
parent d17425cbb8
commit 7d5f3c1338
7 changed files with 28 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
spec/requests/post_readers_controller_spec.rb
View File

@@ -57,15 +57,6 @@ describe PostReadersController do
expect(readers).to be_empty
end
it "doesn't include current_user in the readers list" do
TopicUser.create!(user: admin, topic: @group_message, last_read_post_number: 3)
get '/post_readers.json', params: { id: @post.id }
reader = JSON.parse(response.body)['post_readers'].detect { |r| r['username'] == admin.username }
expect(reader).to be_nil
end
it "doesn't include users without reading progress on first post" do
@post.update(post_number: 1)
TopicUser.create!(user: reader, topic: @group_message, last_read_post_number: nil)