mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
DEV: Multisite tests didn't fail anymore
The change in 9ba8bfb1aa swallowed all exceptions (even syntax errors) which made them appear to pass even if they failed.
This commit is contained in:
@@ -210,13 +210,18 @@ RSpec.configure do |config|
|
|||||||
# force a rollback after using a multisite connection.
|
# force a rollback after using a multisite connection.
|
||||||
def test_multisite_connection(name)
|
def test_multisite_connection(name)
|
||||||
RailsMultisite::ConnectionManagement.with_connection(name) do
|
RailsMultisite::ConnectionManagement.with_connection(name) do
|
||||||
|
spec_exception = nil
|
||||||
|
|
||||||
ActiveRecord::Base.transaction do
|
ActiveRecord::Base.transaction do
|
||||||
begin
|
begin
|
||||||
yield
|
yield
|
||||||
|
rescue Exception => spec_exception
|
||||||
ensure
|
ensure
|
||||||
throw raise ActiveRecord::Rollback
|
raise ActiveRecord::Rollback
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
raise spec_exception if spec_exception
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user