IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FEATURE: Improved deprecation warnings (#6722)

Browse Source 
* FEATURE: Discourse.deprecate can report version

* Ember counterpart for deprecation
This commit is contained in:
Xiao Guan
2018-12-06 12:38:01 +01:00
committed by David Taylor
parent 1d649e147b
commit 7ec124fc89
3 changed files with 44 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
spec/components/discourse_spec.rb
View File

@@ -300,6 +300,24 @@ describe Discourse do
expect(Rails.logger.warnings).to eq([old_method_caller(k)])
end
it 'can report the deprecated version' do
Discourse.deprecate(SecureRandom.hex, since: "2.1.0.beta1")
expect(Rails.logger.warnings[0]).to include("(deprecated since Discourse 2.1.0.beta1)")
end
it 'can report the drop version' do
Discourse.deprecate(SecureRandom.hex, drop_from: "2.3.0")
expect(Rails.logger.warnings[0]).to include("(removal in Discourse 2.3.0)")
end
it 'can raise deprecation error' do
expect {
Discourse.deprecate(SecureRandom.hex, raise_error: true)
}.to raise_error(Discourse::Deprecation)
end
end
end