mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
DEV: Fix system test assertion to avoid stale element reference error (#21944)
What is this change required?
We were seeing this error on CI
```
1) Fast edit when editing text that has strange characters saves when paragraph contains apostrophe
Failure/Error:
expect(find("#{topic_page.post_by_number_selector(2)} .cooked p")).to have_content(
"It ‘twas a great’ “day”!",
)
Selenium::WebDriver::Error::StaleElementReferenceError:
stale element reference: stale element not found
(Session info: chrome=114.0.5735.90)
```
I believe this is because the element that is "found" using `find` is
eventually re-rendered before the `have_content` matcher is called on
it.
This commit is contained in:
committed by
GitHub
parent
5af2f4b888
commit
7ef2eaa892
@@ -47,8 +47,9 @@ describe "Fast edit", type: :system, js: true do
|
|||||||
fast_editor.fill_content("day")
|
fast_editor.fill_content("day")
|
||||||
fast_editor.save
|
fast_editor.save
|
||||||
|
|
||||||
expect(find("#{topic_page.post_by_number_selector(2)} .cooked p")).to have_content(
|
expect(page).to have_selector(
|
||||||
"It ‘twas a great’ “day”!",
|
"#{topic_page.post_by_number_selector(2)} .cooked p",
|
||||||
|
text: "It ‘twas a great’ “day”!",
|
||||||
)
|
)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
Reference in New Issue
Block a user