UX: Fix page content overflow when the setting category list is expanded on mobile (#27983)

app/assets/javascripts/admin/addon/components/admin-site-settings-filter-controls.gjs

@@ -11,6 +11,7 @@ import i18n from "discourse-common/helpers/i18n";
 export default class AdminSiteSettingsFilterControls extends Component {
   @tracked filter = this.args.initialFilter || "";
   @tracked onlyOverridden = false;
+  @tracked isMenuOpen = false;
 
   @action
   clearFilter() {
@@ -47,6 +48,12 @@ export default class AdminSiteSettingsFilterControls extends Component {
     this.onChangeFilter();
   }
 
+  @action
+  toggleMenu() {
+    this.isMenuOpen = !this.isMenuOpen;
+    this.args.onToggleMenu();
+  }
+
   <template>
     <div
       class="admin-controls admin-site-settings-filter-controls"
@@ -57,8 +64,8 @@ export default class AdminSiteSettingsFilterControls extends Component {
         <div class="inline-form">
           {{#if @showMenu}}
             <DButton
-              @action={{@onToggleMenu}}
-              @icon="bars"
+              @action={{this.toggleMenu}}
+              @icon={{if this.isMenuOpen "times" "bars"}}
               class="menu-toggle"
             />
           {{/if}}