IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Ascending/descending sorting in the group membership requests page

Browse Source 
The `GroupsController#members` endpoint accepts a `desc` parameter to determine how members are sorted, but it's been deprecated in favor of a boolean `asc` parameter. However, in the frontend, specifically the group membership requests page was not updated entirely to use the `asc` param and it still passes a `desc` param when changing how group requests are sorted.

This commit updates the `group-requests` Ember controller so it passes a boolean `asc` param and removes all references of `desc`. The controller view/template has already been updated to use `asc`:

207c3085fc/app/assets/javascripts/discourse/app/templates/group-requests.hbs (L15-L16)
This commit is contained in:
Osama Sayegh 2021-07-16 11:02:24 +03:00 committed by GitHub
parent c4d7545f35
commit 810892139b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/assets/javascripts/discourse/app/controllers/group-requests.js
View File

@ -7,10 +7,10 @@ import { popupAjaxError } from "discourse/lib/ajax-error";
export default Controller.extend({ export default Controller.extend({
application: controller(), application: controller(),
queryParams: ["order", "desc", "filter"], queryParams: ["order", "asc", "filter"],
order: "", order: "",
desc: null, asc: null,
filter: null, filter: null,
filterInput: null, filterInput: null,
@ -27,7 +27,7 @@ export default Controller.extend({
); );
}, },
@observes("order", "desc", "filter") @observes("order", "asc", "filter")
_filtersChanged() { _filtersChanged() {
this.findRequesters(true); this.findRequesters(true);
}, },
@ -57,9 +57,9 @@ export default Controller.extend({
}); });
}, },
@discourseComputed("order", "desc", "filter") @discourseComputed("order", "asc", "filter")
memberParams(order, desc, filter) { memberParams(order, asc, filter) {
return { order, desc, filter }; return { order, asc, filter };
}, },
@discourseComputed("model.requesters.[]") @discourseComputed("model.requesters.[]")