IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 10:20:58 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Fix flaky tests due to the lack of ordering (#23910)

Browse Source 
Why this change?

The following test was flaky due to the lack of ordering in
`SiteSerializer#anonymous_default_navigation_menu_tags` when fetching
the tags.

```
  1) SiteSerializer#anonymous_default_navigation_menu_tags includes only tags user can see in the serialised object when user is anonymous
     Failure/Error:
       expect(serialized[:anonymous_default_navigation_menu_tags]).to eq(
         [
           { name: "dev", description: "some description", pm_only: false },
           { name: "random", description: tag2.description, pm_only: false },
         ],
       )
```

What does this change do?

Add ordering by name when fetching tags in `SiteSerializer#anonymous_default_navigation_menu_tags`
This commit is contained in:
Alan Guo Xiang Tan 2023-10-20 08:18:49 +08:00 committed by GitHub
parent 700c636d29
commit 81c2d38cea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/serializers/site_serializer.rb
View File

@ -278,7 +278,7 @@ class SiteSerializer < ApplicationSerializer
SiteSetting.default_navigation_menu_tags.split("|") - SiteSetting.default_navigation_menu_tags.split("|") -
DiscourseTagging.hidden_tag_names(scope) DiscourseTagging.hidden_tag_names(scope)
serialize_tags(Tag.where(name: tag_names)) serialize_tags(Tag.where(name: tag_names).order(:name))
end end
end end