IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Prepare plugin-outlet for ember upgrade (#24567)

Browse Source 
In modern versions of Ember, `this.parentView` is called internally during component init. We don't want our deprecation message to be triggered by that internal call, so we need an additional check.

Extracted from https://github.com/discourse/discourse/pull/21720
This commit is contained in:
David Taylor 2023-11-27 13:43:02 +00:00 committed by GitHub
parent 86f3e86596
commit 824878f315
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/javascripts/discourse/app/components/plugin-outlet.js
View File

@ -145,7 +145,11 @@ class PluginOutletWithTagNameWrapper extends ClassicComponent {
// Overridden parentView to make this wrapper 'transparent' // Overridden parentView to make this wrapper 'transparent'
// Calling this will trigger the deprecation notice in PluginOutletComponent // Calling this will trigger the deprecation notice in PluginOutletComponent
get parentView() { get parentView() {
return this._parentView.parentView; // init() of CoreView calls `this.parentView`. That would trigger the deprecation notice,
// so skip it until this component is initialized.
if (this._state) {
return this._parentView.parentView;
}
} }
set parentView(value) { set parentView(value) {
this._parentView = value; this._parentView = value;