From 847f48a9d0fe42344c9562ac715ce46a8454f1be Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Mon, 7 Oct 2019 13:48:26 -0400 Subject: [PATCH] Add an app event for when a topic is fully loaded If we are interested in page events (say analytics), they are reported when the route changes, which does not wait for any promises in `setupController` to finish. A plugin might want to know when a topic has fully loaded, so this event is triggered when that happens. --- app/assets/javascripts/discourse/routes/topic-from-params.js.es6 | 1 + 1 file changed, 1 insertion(+) diff --git a/app/assets/javascripts/discourse/routes/topic-from-params.js.es6 b/app/assets/javascripts/discourse/routes/topic-from-params.js.es6 index 70f56403e98..c193cbe98c5 100644 --- a/app/assets/javascripts/discourse/routes/topic-from-params.js.es6 +++ b/app/assets/javascripts/discourse/routes/topic-from-params.js.es6 @@ -52,6 +52,7 @@ export default Discourse.Route.extend({ enteredAt: new Date().getTime().toString() }); + this.appEvents.trigger("page:topic-loaded", topic); topicController.subscribe(); // Highlight our post after the next render