mirror of
https://github.com/discourse/discourse.git
synced 2024-11-29 20:24:05 -06:00
FIX: Close navigation dropdown when item selected (#12155)
This `if` statement was backwards, such that it was a no-op. This hasn't caused a problem because clicking an item triggers a page load, which destroys and recreates the component. However, we are soon planning to remove the intermediate loading screen, which means the component will not be removed/recreated. https://meta.discourse.org/t/177939/202
This commit is contained in:
parent
04c75d417b
commit
863c7919d7
@ -52,7 +52,7 @@ export default Component.extend(FilterModeMixin, {
|
||||
},
|
||||
|
||||
ensureDropClosed() {
|
||||
if (!this.expanded) {
|
||||
if (this.expanded) {
|
||||
this.set("expanded", false);
|
||||
}
|
||||
$(window).off("click.navigation-bar");
|
||||
|
Loading…
Reference in New Issue
Block a user