IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-16 18:24:52 -06:00
Code Issues Packages Projects Releases Wiki Activity

Revert "PERF: Prefer joins over subquery for User#private_posts_for_user."

Browse Source 
This reverts commit 05b43e5ae4.
This commit is contained in:
Guo Xiang Tan 2020-08-17 14:58:47 +08:00
parent 05b43e5ae4
commit 872ef82f4d
No known key found for this signature in database
GPG Key ID: FBD110179AAC1F20
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/models/post.rb
View File

@ -80,10 +80,7 @@ class Post < ActiveRecord::Base
register_custom_field_type(MISSING_UPLOADS_IGNORED, :boolean)
scope :private_posts_for_user, ->(user) {
joins("LEFT JOIN topic_allowed_users ON topic_allowed_users.topic_id = posts.topic_id AND topic_allowed_users.user_id = #{user.id.to_i}")
.joins("LEFT JOIN group_users ON group_users.user_id = #{user.id.to_i}")
.joins("LEFT JOIN topic_allowed_groups ON topic_allowed_groups.topic_id = posts.topic_id AND topic_allowed_groups.group_id = group_users.group_id")
.where("topic_allowed_users.topic_id IS NOT NULL OR topic_allowed_groups.topic_id IS NOT NULL")
where("posts.topic_id IN (#{Topic::PRIVATE_MESSAGES_SQL})", user_id: user.id)
}
scope :by_newest, -> { order('created_at DESC, id DESC') }