mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
FEATURE: Support for localized themes (#6848)
- Themes can supply translation files in a format like `/locales/{locale}.yml`. These files should be valid YAML, with a single top level key equal to the locale being defined. For now these can only be defined using the `discourse_theme` CLI, importing a `.tar.gz`, or from a GIT repository.
- Fallback is handled on a global level (if the locale is not defined in the theme), as well as on individual keys (if some keys are missing from the selected interface language).
- Administrators can override individual keys on a per-theme basis in the /admin/customize/themes user interface.
- Theme developers should access defined translations using the new theme prefix variables:
JavaScript: `I18n.t(themePrefix("my_translation_key"))`
Handlebars: `{{theme-i18n "my_translation_key"}}` or `{{i18n (theme-prefix "my_translation_key")}}`
- To design for backwards compatibility, theme developers can check for the presence of the `themePrefix` variable in JavaScript
- As part of this, the old `{{themeSetting.setting_name}}` syntax is deprecated in favour of `{{theme-setting "setting_name"}}`
This commit is contained in:
@@ -207,6 +207,47 @@ describe Admin::ThemesController do
|
||||
expect(UserHistory.where(action: UserHistory.actions[:change_theme]).count).to eq(1)
|
||||
end
|
||||
|
||||
it 'can update translations' do
|
||||
theme.set_field(target: :translations, name: :en, value: { en: { somegroup: { somestring: "defaultstring" } } }.deep_stringify_keys.to_yaml)
|
||||
theme.save!
|
||||
|
||||
put "/admin/themes/#{theme.id}.json", params: {
|
||||
theme: {
|
||||
translations: {
|
||||
"somegroup.somestring" => "overridenstring"
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
# Response correct
|
||||
expect(response.status).to eq(200)
|
||||
json = ::JSON.parse(response.body)
|
||||
expect(json["theme"]["translations"][0]["value"]).to eq("overridenstring")
|
||||
|
||||
# Database correct
|
||||
theme.reload
|
||||
expect(theme.theme_translation_overrides.count).to eq(1)
|
||||
expect(theme.theme_translation_overrides.first.translation_key).to eq("somegroup.somestring")
|
||||
|
||||
# Set back to default
|
||||
put "/admin/themes/#{theme.id}.json", params: {
|
||||
theme: {
|
||||
translations: {
|
||||
"somegroup.somestring" => "defaultstring"
|
||||
}
|
||||
}
|
||||
}
|
||||
# Response correct
|
||||
expect(response.status).to eq(200)
|
||||
json = ::JSON.parse(response.body)
|
||||
expect(json["theme"]["translations"][0]["value"]).to eq("defaultstring")
|
||||
|
||||
# Database correct
|
||||
theme.reload
|
||||
expect(theme.theme_translation_overrides.count).to eq(0)
|
||||
|
||||
end
|
||||
|
||||
it 'returns the right error message' do
|
||||
theme.update!(component: true)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user