IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Remove invalid pretender calls (#18341)

Browse Source 
Get parameters cannot be included in the URL of request stubs. Instead, the callback can check `request.queryParams` to modify behavior.
This commit is contained in:
David Taylor 2022-09-23 12:07:23 +01:00 committed by GitHub
parent 7277a9fbb3
commit 8964749989
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/discourse/tests/acceptance/redirect-to-top-test.js
View File

@ -8,9 +8,6 @@ import { test } from "qunit";
acceptance("Redirect to Top", function (needs) { acceptance("Redirect to Top", function (needs) {
needs.pretender((server, helper) => { needs.pretender((server, helper) => {
server.get("/top.json?period=weekly", () => {
return helper.response(DiscoveryFixtures["/latest.json"]);
});
server.get("/top/monthly.json", () => { server.get("/top/monthly.json", () => {
return helper.response(DiscoveryFixtures["/latest.json"]); return helper.response(DiscoveryFixtures["/latest.json"]);
}); });

10
app/assets/javascripts/discourse/tests/acceptance/topic-discovery-test.js
View File

@ -201,15 +201,11 @@ acceptance("Topic Discovery | Footer", function (needs) {
}); });
needs.pretender((server, helper) => { needs.pretender((server, helper) => {
server.get("/c/dev/7/l/latest.json", () => { server.get("/c/dev/7/l/latest.json", (request) => {
const json = cloneJSON(discoveryFixtures["/c/dev/7/l/latest.json"]); const json = cloneJSON(discoveryFixtures["/c/dev/7/l/latest.json"]);
if (!request.queryParams.page) {
json.topic_list.more_topics_url = "/c/dev/7/l/latest.json?page=2"; json.topic_list.more_topics_url = "/c/dev/7/l/latest.json?page=2";
return helper.response(json); }
});
server.get("/c/dev/7/l/latest.json?page=2", () => {
const json = cloneJSON(discoveryFixtures["/c/dev/7/l/latest.json"]);
json.topic_list.more_topics_url = null;
return helper.response(json); return helper.response(json);
}); });
}); });