IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-11 13:35:20 -05:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Rails 5.2 upgrade and global gem upgrade

Browse Source 
This updates tests to use latest rails 5 practice
and updates ALL dependencies that could be updated

Performance testing shows that performance has not regressed
if anything it is marginally faster now.
This commit is contained in:
Sam
2018-06-07 14:21:33 +10:00
parent 2bd905c632
commit 89ad2b5900
103 changed files with 900 additions and 864 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/requests/directory_items_controller_spec.rb
+8 -8
View File
@@ -14,7 +14,7 @@ describe DirectoryItemsController do
it "requires a proper `period` param" do
get '/directory_items.json', params: { period: 'eviltrout' }
expect(response).not_to be_success
expect(response).not_to be_successful
end
context "without data" do
@@ -24,7 +24,7 @@ describe DirectoryItemsController do
it "succeeds" do
get '/directory_items.json', params: { period: 'all' }
expect(response).to be_success
expect(response).to be_successful
end
end
@@ -37,7 +37,7 @@ describe DirectoryItemsController do
it "succeeds with a valid value" do
get '/directory_items.json', params: { period: 'all' }
expect(response).to be_success
expect(response).to be_successful
json = ::JSON.parse(response.body)
expect(json).to be_present
@@ -53,12 +53,12 @@ describe DirectoryItemsController do
SiteSetting.enable_user_directory = false
get '/directory_items.json', params: { period: 'all' }
expect(response).not_to be_success
expect(response).not_to be_successful
end
it "finds user by name" do
get '/directory_items.json', params: { period: 'all', name: 'eviltrout' }
expect(response).to be_success
expect(response).to be_successful
json = ::JSON.parse(response.body)
expect(json).to be_present
@@ -69,7 +69,7 @@ describe DirectoryItemsController do
it "finds staged user by name" do
get '/directory_items.json', params: { period: 'all', name: 'stage_user' }
expect(response).to be_success
expect(response).to be_successful
json = ::JSON.parse(response.body)
expect(json).to be_present
@@ -80,7 +80,7 @@ describe DirectoryItemsController do
it "excludes users by username" do
get '/directory_items.json', params: { period: 'all', exclude_usernames: "stage_user,eviltrout" }
expect(response).to be_success
expect(response).to be_successful
json = ::JSON.parse(response.body)
expect(json).to be_present
@@ -92,7 +92,7 @@ describe DirectoryItemsController do
it "filters users by group" do
get '/directory_items.json', params: { period: 'all', group: group.name }
expect(response).to be_success
expect(response).to be_successful
json = ::JSON.parse(response.body)
expect(json).to be_present