DEV: Rails 5.2 upgrade and global gem upgrade

This updates tests to use latest rails 5 practice
and updates ALL dependencies that could be updated

Performance testing shows that performance has not regressed
if anything it is marginally faster now.
This commit is contained in:
Sam
2018-06-05 17:29:17 +10:00
parent 2bd905c632
commit 89ad2b5900
103 changed files with 900 additions and 864 deletions

View File

@@ -98,7 +98,7 @@ describe StaticController do
it "should return the right response" do
get "/faq"
expect(response).to be_success
expect(response).to be_successful
expect(response.body).to include(I18n.t('js.faq'))
end
end
@@ -113,7 +113,7 @@ describe StaticController do
it "renders the #{id} page" do
get "/#{id}"
expect(response).to be_success
expect(response).to be_successful
expect(response.body).to include(text)
end
end
@@ -150,7 +150,7 @@ describe StaticController do
get "/login"
expect(response).to be_success
expect(response).to be_successful
expect(response.body).to include(PrettyText.cook(I18n.t(
'login_required.welcome_message', title: SiteSetting.title
@@ -177,7 +177,7 @@ describe StaticController do
get '/faq'
expect(response).to be_success
expect(response).to be_successful
expect(response.body).to include(I18n.t('js.faq'))
end
@@ -186,7 +186,7 @@ describe StaticController do
get '/guidelines'
expect(response).to be_success
expect(response).to be_successful
expect(response.body).to include(I18n.t('guidelines'))
end
end