From 8a90a5610feb9753b40a80ce0c99cead5adbdf1d Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Fri, 20 Nov 2020 17:34:55 +0100 Subject: [PATCH] DEV: allows to check if an icon is in the set (#11303) --- .../javascripts/discourse-common/addon/lib/icon-library.js | 7 ++++++- app/assets/javascripts/discourse/app/lib/plugin-api.js | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/discourse-common/addon/lib/icon-library.js b/app/assets/javascripts/discourse-common/addon/lib/icon-library.js index 376fbce8e28..3dba881c92f 100644 --- a/app/assets/javascripts/discourse-common/addon/lib/icon-library.js +++ b/app/assets/javascripts/discourse-common/addon/lib/icon-library.js @@ -114,8 +114,13 @@ export function setIconList(iconList) { _iconList = iconList; } +export function isExistingIconId(id) { + // _iconList is actually an array as a string: '["foo", "bar"]' + return _iconList && _iconList.indexOf(`"${id}"`) >= 0; +} + function warnIfMissing(id) { - if (warnMissingIcons && _iconList && _iconList.indexOf(id) === -1) { + if (warnMissingIcons && !isExistingIconId(id)) { console.warn(`The icon "${id}" is missing from the SVG subset.`); // eslint-disable-line no-console } } diff --git a/app/assets/javascripts/discourse/app/lib/plugin-api.js b/app/assets/javascripts/discourse/app/lib/plugin-api.js index 4e2072948ec..34b30d1478c 100644 --- a/app/assets/javascripts/discourse/app/lib/plugin-api.js +++ b/app/assets/javascripts/discourse/app/lib/plugin-api.js @@ -67,7 +67,7 @@ import { } from "discourse/models/user"; // If you add any methods to the API ensure you bump up this number -const PLUGIN_API_VERSION = "0.11.0"; +const PLUGIN_API_VERSION = "0.11.1"; class PluginApi { constructor(version, container) {