IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: do not reload identical route in drawer (#27992)

Browse Source 
This is a performance optimisation to prevent the same route to keep reloading the same endpoint.

No tests as it's not changing behavior and is also quite complex to test efficiently.
This commit is contained in:
Joffrey JAFFEUX 2024-07-19 22:27:32 +02:00 committed by GitHub
parent 346c9116b5
commit 8b18fd1556
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/chat/assets/javascripts/discourse/routes/chat.js
View File

@ -34,6 +34,10 @@ export default class ChatRoute extends DiscourseRoute {
) {
transition.abort();
if (this.chatDrawerRouter.currentRouteName === transition.targetName) {
return;
}
let url = transition.intent.url;
if (transition.targetName.startsWith("chat.channel")) {
url ??= this.router.urlFor(

1
plugins/chat/assets/javascripts/discourse/services/chat-drawer-router.js
View File

@ -146,6 +146,7 @@ export default class ChatDrawerRouter extends Service {
this.drawerRoute = ROUTES[route.name];
this.params = this.drawerRoute?.extractParams?.(route) || route.params;
this.component = this.drawerRoute?.name || ChatDrawerRoutesChannels;
this.currentRouteName = route.name;
this.drawerRoute.activate?.(route);
}

2
plugins/chat/assets/javascripts/discourse/services/chat-state-manager.js
View File

@ -26,6 +26,7 @@ export default class ChatStateManager extends Service {
@service chatHistory;
@service router;
@service site;
@service chatDrawerRouter;
@tracked isSidePanelExpanded = false;
@tracked isDrawerExpanded = false;
@ -118,6 +119,7 @@ export default class ChatStateManager extends Service {
}
});
this.chatDrawerRouter.currentRouteName = null;
this.isDrawerActive = false;
this.isDrawerExpanded = false;
this.chat.updatePresence();