IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 09:26:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Use <> link instead of code for discobot backup image link (#11063)

Browse Source 
Due to the new enhanced copy-paste handling, the URL would be included in the user's reply as code, too!
By surrounding the link in angle brackets, we prevent the bot from accidentally including the link itself and spoiling the surprise.

I considered having the bot automatically edit the user's post to remove the backticks. I very quickly ran into a problem with spurious whitespace, and it would also look _super weird_ for the bot to edit your post when that's not what's being taught.
The seemingly bare link not automatically embedding is also weird, but slightly less so.

Fun fact: this doesn't work on localhost, because the onebox engine refuses to issue requests to localhost :)
This commit is contained in:
Kane York 2020-10-29 17:57:27 -07:00 committed by GitHub
parent 2d5bb516a6
commit 8b24e0f0b7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/discourse-narrative-bot/config/locales/server.en.yml
View File

@ -199,7 +199,7 @@ en:
not_found: |-
Looks like you didn’t upload an image so I’ve chosen a picture that I’m _sure_ you will enjoy.
`%{image_url}`
<%{image_url}>
Try uploading that one next, or pasting the link in on a line by itself!