mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
FIX: Topic title should be included in post webhook payload.
This commit is contained in:
parent
aec73d4003
commit
8b2e3bf5f1
@ -1,17 +1,17 @@
|
|||||||
class WebHookPostSerializer < PostSerializer
|
class WebHookPostSerializer < PostSerializer
|
||||||
def include_can_edit?
|
def include_topic_title?
|
||||||
false
|
true
|
||||||
end
|
end
|
||||||
|
|
||||||
def can_delete
|
%i{
|
||||||
false
|
can_view
|
||||||
end
|
can_edit
|
||||||
|
can_delete
|
||||||
def can_recover
|
can_recover
|
||||||
false
|
can_wiki
|
||||||
end
|
}.each do |attr|
|
||||||
|
define_method("include_#{attr}?") do
|
||||||
def can_wiki
|
false
|
||||||
false
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
24
spec/serializers/web_hook_post_serializer_spec.rb
Normal file
24
spec/serializers/web_hook_post_serializer_spec.rb
Normal file
@ -0,0 +1,24 @@
|
|||||||
|
require 'rails_helper'
|
||||||
|
|
||||||
|
RSpec.describe WebHookPostSerializer do
|
||||||
|
let(:admin) { Fabricate(:admin) }
|
||||||
|
let(:post) { Fabricate(:post) }
|
||||||
|
let(:serializer) { WebHookPostSerializer.new(post, scope: Guardian.new(admin), root: false) }
|
||||||
|
|
||||||
|
it 'should only include the required keys' do
|
||||||
|
count = serializer.as_json.keys.count
|
||||||
|
difference = count - 40
|
||||||
|
|
||||||
|
expect(difference).to eq(0), lambda {
|
||||||
|
message = ""
|
||||||
|
|
||||||
|
if difference < 0
|
||||||
|
message << "#{difference * -1} key(s) have been removed from this serializer."
|
||||||
|
else
|
||||||
|
message << "#{difference} key(s) have been added to this serializer."
|
||||||
|
end
|
||||||
|
|
||||||
|
message << "\nPlease verify if those key(s) are required as part of the web hook's payload."
|
||||||
|
}
|
||||||
|
end
|
||||||
|
end
|
Loading…
Reference in New Issue
Block a user