From 8bb911e038cc626016a6cf0e988d7608ab7ea5d3 Mon Sep 17 00:00:00 2001 From: David Taylor Date: Wed, 27 Oct 2021 17:49:23 +0100 Subject: [PATCH] DEV: Teardown appEvent listener in edit-notification-clicks-tracker --- .../edit-notification-clicks-tracker.js | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/app/assets/javascripts/discourse/app/initializers/edit-notification-clicks-tracker.js b/app/assets/javascripts/discourse/app/initializers/edit-notification-clicks-tracker.js index c9e29142ac7..8146c40218b 100644 --- a/app/assets/javascripts/discourse/app/initializers/edit-notification-clicks-tracker.js +++ b/app/assets/javascripts/discourse/app/initializers/edit-notification-clicks-tracker.js @@ -4,13 +4,15 @@ export default { name: "edit-notification-clicks-tracker", initialize(container) { - container - .lookup("service:app-events") - .on( - "edit-notification:clicked", - ({ topicId, postNumber, revisionNumber }) => { - setLastEditNotificationClick(topicId, postNumber, revisionNumber); - } - ); + this.appEvents = container.lookup("service:app-events"); + this.appEvents.on("edit-notification:clicked", this, this.handleClick); + }, + + handleClick({ topicId, postNumber, revisionNumber }) { + setLastEditNotificationClick(topicId, postNumber, revisionNumber); + }, + + teardown() { + this.appEvents.off("edit-notification:clicked", this, this.handleClick); }, };