IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

A11Y: Don't mark multiple form labels as applying to the same element (#13289)

Browse Source 
Co-authored-by: Jordan Vidrine <jordan@jordanvidrine.com>
This commit is contained in:
Penar Musaraj
2021-06-09 11:06:56 -04:00
committed by GitHub
parent 77d33ebe21
commit 8fee32d277
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/assets/javascripts/discourse/app/templates/modal/create-account.hbs
View File

@@ -35,7 +35,7 @@
</label> </label>
{{/if}} {{/if}}
{{input-tip validation=emailValidation id="account-email-validation"}} {{input-tip validation=emailValidation id="account-email-validation"}}
<label class="more-info" for="new-account-email">{{i18n "user.email.instructions"}}</label> <span class="more-info">{{i18n "user.email.instructions"}}</span>
</div> </div>
<div class="input-group"> <div class="input-group">
@@ -53,7 +53,7 @@
{{/if}} {{/if}}
{{input-tip validation=usernameValidation id="username-validation"}} {{input-tip validation=usernameValidation id="username-validation"}}
<label class="more-info" for="new-account-username">{{i18n "user.username.instructions"}}</label> <span class="more-info">{{i18n "user.username.instructions"}}</span>
</div> </div>
<div class="input-group"> <div class="input-group">
@@ -74,7 +74,7 @@
{{/if}} {{/if}}
{{input-tip validation=nameValidation}} {{input-tip validation=nameValidation}}
<label class="more-info" for="new-account-name">{{nameInstructions}}</label> <span class="more-info">{{nameInstructions}}</span>
{{/if}} {{/if}}
</div> </div>
@@ -101,7 +101,7 @@
</label> </label>
{{input-tip validation=passwordValidation}} {{input-tip validation=passwordValidation}}
<label class="more-info" for="new-account-password">{{passwordInstructions}}</label> <span class="more-info">{{passwordInstructions}}</span>
<div class="caps-lock-warning {{unless capsLockOn " hidden"}}"> <div class="caps-lock-warning {{unless capsLockOn " hidden"}}">
{{d-icon "exclamation-triangle"}} {{i18n "login.caps_lock_warning"}} {{d-icon "exclamation-triangle"}} {{i18n "login.caps_lock_warning"}}
</div> </div>
@@ -118,7 +118,7 @@
<div class="input-group"> <div class="input-group">
{{input value=inviteCode class=(value-entered inviteCode) id="inviteCode"}} {{input value=inviteCode class=(value-entered inviteCode) id="inviteCode"}}
<label class="alt-placeholder" for="invite-code">{{i18n "user.invite_code.title"}}</label> <label class="alt-placeholder" for="invite-code">{{i18n "user.invite_code.title"}}</label>
<label class="more-info" for="invite-code">{{i18n "user.invite_code.instructions"}}</label> <span class="more-info">{{i18n "user.invite_code.instructions"}}</span>
</div> </div>
{{/if}} {{/if}}

2
app/assets/stylesheets/common/base/login.scss
View File

@@ -140,7 +140,7 @@
border: 1px solid var(--tertiary); border: 1px solid var(--tertiary);
box-shadow: 0 0 0 2px rgba(var(--tertiary-rgb), 0.25); box-shadow: 0 0 0 2px rgba(var(--tertiary-rgb), 0.25);
} }
label.more-info { span.more-info {
color: var(--primary-medium); color: var(--primary-medium);
min-height: 1.4em; // prevents height increase due to tips min-height: 1.4em; // prevents height increase due to tips
} }