IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-01 13:09:33 -06:00
Code Issues Packages Projects Releases Wiki Activity

BUGFIX: fragile test corrected, stubbing is not needed here.

Browse Source
This commit is contained in:
Sam 2014-06-12 10:59:07 +10:00
parent 8c7363bdd5
commit 8ff4536a08
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/javascripts/controllers/notification_controller_test.js
View File

@ -9,16 +9,10 @@ var notificationFixture = {
display_username: "velesin" display_username: "velesin"
} }
}; };
var postUrlStub = "post-url-stub";
module("controller:notification", { module("controller:notification", {
setup: function() { setup: function() {
sinon.stub(Discourse.Utilities, "postUrl").returns(postUrlStub);
controller = testController('notification', notificationFixture); controller = testController('notification', notificationFixture);
},
teardown: function() {
Discourse.Utilities.postUrl.restore();
} }
}); });
@ -42,7 +36,6 @@ test("link property returns empty string when there is no topic title", function
test("link property returns correctly built link when there is a topic title", function() { test("link property returns correctly built link when there is a topic title", function() {
var $link = $(controller.get("link")); var $link = $(controller.get("link"));
ok(Discourse.Utilities.postUrl.calledWithExactly("a-slug", 1234, 1), "URL is generated with the correct slug, topic ID and post number"); equal($link.attr("href"), "/t/a-slug/1234", "generated link points to a correct URL");
equal($link.attr("href"), postUrlStub, "generated link points to a correct URL");
equal($link.text(), "some title", "generated link has correct text"); equal($link.text(), "some title", "generated link has correct text");
}); });