IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Use a better default for the low_priority_threshold setting. (#13161)

Browse Source 
Using 1 as the default value is confusing for some people as low-score flags are hidden unless staff uses the "(any)" priority filter. Let's change it to 0 and let every site adjust the setting to match their needs.
This commit is contained in:
Roman Rizzi 2021-05-26 13:16:16 -03:00 committed by GitHub
parent ea61bcaf13
commit 91ee3fb6e3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 35 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
config/site_settings.yml
View File

@ -1714,8 +1714,8 @@ spam:
default: low default: low
enum: "ReviewablePrioritySetting" enum: "ReviewablePrioritySetting"
reviewable_low_priority_threshold: reviewable_low_priority_threshold:
default: 1 default: 0
min: 1 min: 0
rate_limits: rate_limits:
unique_posts_mins: 5 unique_posts_mins: 5

60
spec/jobs/reviewable_priorities_spec.rb
View File

@ -40,41 +40,47 @@ describe Jobs::ReviewablePriorities do
expect(Reviewable.score_required_to_hide_post).to eq(8.33) expect(Reviewable.score_required_to_hide_post).to eq(8.33)
end end
it "will set priorities based on the maximum score" do context 'when there are enough reviewables' do
create_reviewables(Jobs::ReviewablePriorities.min_reviewables) let(:medium_threshold) { 8.0 }
let(:high_threshold) { 13.0 }
let(:score_to_hide_post) { 8.66 }
Jobs::ReviewablePriorities.new.execute({}) it "will set priorities based on the maximum score" do
create_reviewables(Jobs::ReviewablePriorities.min_reviewables)
expect_min_score(:low, SiteSetting.reviewable_low_priority_threshold) Jobs::ReviewablePriorities.new.execute({})
expect_min_score(:medium, 9.0)
expect_min_score(:high, 14.0)
expect(Reviewable.score_required_to_hide_post).to eq(9.33)
end
it 'ignore negative scores when calculating priorities' do expect_min_score(:low, SiteSetting.reviewable_low_priority_threshold)
create_reviewables(Jobs::ReviewablePriorities.min_reviewables) expect_min_score(:medium, medium_threshold)
negative_score = -9 expect_min_score(:high, high_threshold)
10.times { create_with_score(negative_score) } expect(Reviewable.score_required_to_hide_post).to eq(score_to_hide_post)
end
Jobs::ReviewablePriorities.new.execute({}) it 'ignore negative scores when calculating priorities' do
create_reviewables(Jobs::ReviewablePriorities.min_reviewables)
negative_score = -9
10.times { create_with_score(negative_score) }
expect_min_score(:low, SiteSetting.reviewable_low_priority_threshold) Jobs::ReviewablePriorities.new.execute({})
expect_min_score(:medium, 9.0)
expect_min_score(:high, 14.0)
expect(Reviewable.score_required_to_hide_post).to eq(9.33)
end
it 'ignores non-approved reviewables' do expect_min_score(:low, SiteSetting.reviewable_low_priority_threshold)
create_reviewables(Jobs::ReviewablePriorities.min_reviewables) expect_min_score(:medium, medium_threshold)
low_score = 2 expect_min_score(:high, high_threshold)
10.times { create_with_score(low_score, status: :pending) } expect(Reviewable.score_required_to_hide_post).to eq(score_to_hide_post)
end
Jobs::ReviewablePriorities.new.execute({}) it 'ignores non-approved reviewables' do
create_reviewables(Jobs::ReviewablePriorities.min_reviewables)
low_score = 2
10.times { create_with_score(low_score, status: :pending) }
expect_min_score(:low, SiteSetting.reviewable_low_priority_threshold) Jobs::ReviewablePriorities.new.execute({})
expect_min_score(:medium, 9.0)
expect_min_score(:high, 14.0) expect_min_score(:low, SiteSetting.reviewable_low_priority_threshold)
expect(Reviewable.score_required_to_hide_post).to eq(9.33) expect_min_score(:medium, medium_threshold)
expect_min_score(:high, high_threshold)
expect(Reviewable.score_required_to_hide_post).to eq(score_to_hide_post)
end
end end
def expect_min_score(priority, score) def expect_min_score(priority, score)