IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

UX: show caret only in topic footer buttons dropdown select boxes (#9816)

Browse Source
This commit is contained in:
Joffrey JAFFEUX 2020-05-18 14:07:40 +02:00 committed by GitHub
parent f968155288
commit 9482ddff73
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/assets/javascripts/discourse/app/widgets/topic-timeline.js
View File

@ -390,7 +390,8 @@ createWidget("timeline-footer-controls", {
showFullTitle: false, showFullTitle: false,
appendReason: false, appendReason: false,
placement: "bottom-end", placement: "bottom-end",
mountedAsWidget: true mountedAsWidget: true,
showCaret: false
}, },
["notificationLevel"] ["notificationLevel"]
) )

4
app/assets/javascripts/select-kit/app/components/pinned-options.js
View File

@ -9,6 +9,10 @@ export default DropdownSelectBoxComponent.extend({
pluginApiIdentifiers: ["pinned-options"], pluginApiIdentifiers: ["pinned-options"],
classNames: ["pinned-options"], classNames: ["pinned-options"],
selectKitOptions: {
showCaret: true
},
modifySelection(content) { modifySelection(content) {
const pinnedGlobally = this.get("topic.pinned_globally"); const pinnedGlobally = this.get("topic.pinned_globally");
const pinned = this.value; const pinned = this.value;

1
app/assets/javascripts/select-kit/app/components/topic-notifications-button.js
View File

@ -9,6 +9,7 @@ export default Component.extend({
placement: "bottom-start", placement: "bottom-start",
notificationLevel: null, notificationLevel: null,
topic: null, topic: null,
showCaret: true,
@action @action
changeTopicNotificationLevel(levelId) { changeTopicNotificationLevel(levelId) {

3
app/assets/javascripts/select-kit/app/components/topic-notifications-options.js
View File

@ -9,7 +9,8 @@ export default NotificationsButtonComponent.extend({
selectKitOptions: { selectKitOptions: {
i18nPrefix: "i18nPrefix", i18nPrefix: "i18nPrefix",
i18nPostfix: "i18nPostfix" i18nPostfix: "i18nPostfix",
showCaret: true
}, },
i18nPrefix: "topic.notifications", i18nPrefix: "topic.notifications",

4
app/assets/javascripts/select-kit/app/templates/components/dropdown-select-box/dropdown-select-box-header.hbs
View File

@ -7,4 +7,6 @@
shouldDisplayClearableButton=shouldDisplayClearableButton shouldDisplayClearableButton=shouldDisplayClearableButton
}} }}
{{d-icon caretIcon class="caret-icon"}} {{#if selectKit.options.showCaret}}
{{d-icon caretIcon class="caret-icon"}}
{{/if}}

1
app/assets/javascripts/select-kit/app/templates/components/topic-notifications-button.hbs
View File

@ -6,6 +6,7 @@
showFullTitle=showFullTitle showFullTitle=showFullTitle
placement=placement placement=placement
preventsClickPropagation=true preventsClickPropagation=true
showCaret=showCaret
) )
}} }}