IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

UX: update member visibility help text to include flair information (#13995)

Browse Source
This commit is contained in:
Arpit Jalan 2021-08-10 19:31:29 +05:30 committed by GitHub
parent 6d41c37c16
commit 97f701bc4c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/assets/javascripts/discourse/app/components/groups-form-interaction-fields.js
View File

@ -97,4 +97,15 @@ export default Component.extend({
canAdminGroup(isCreated, canAdmin, canCreate) { canAdminGroup(isCreated, canAdmin, canCreate) {
return (!isCreated && canCreate) || (isCreated && canAdmin); return (!isCreated && canCreate) || (isCreated && canAdmin);
}, },
@discourseComputed("membersVisibilityLevel")
membersVisibilityLevelsDescription(membersVisibilityLevel) {
if (
membersVisibilityLevel === this.visibilityLevelOptions.firstObject.value
) {
return "admin.groups.manage.interaction.members_visibility_levels.description";
} else {
return "admin.groups.manage.interaction.members_visibility_levels.description_flair_visible";
}
},
}); });

2
app/assets/javascripts/discourse/app/templates/components/groups-form-interaction-fields.hbs
View File

@ -30,7 +30,7 @@
}} }}
<div class="control-instructions"> <div class="control-instructions">
{{i18n "admin.groups.manage.interaction.members_visibility_levels.description"}} {{i18n membersVisibilityLevelsDescription}}
</div> </div>
</div> </div>
{{/if}} {{/if}}

1
config/locales/client.en.yml
View File

@ -3919,6 +3919,7 @@ en:
members_visibility_levels: members_visibility_levels:
title: "Who can see this group's members?" title: "Who can see this group's members?"
description: "Admins can see members of all groups." description: "Admins can see members of all groups."
description_flair_visible: "Admins can see members of all groups. Flair is visible to all users."
publish_read_state: "On group messages publish group read state" publish_read_state: "On group messages publish group read state"
membership: membership: