IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-20 11:48:26 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Clarify security key copy (#18636)

Browse Source 
In user preferences, we want to make it more obvious
that a security key is a physical device, and also
you can use your phone.
This commit is contained in:
Martin Brennan 2022-10-18 16:30:48 +10:00 committed by GitHub
parent 243efa8931
commit 9879cb0e68
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/assets/javascripts/discourse/app/controllers/second-factor-add-security-key.js
View File

@ -13,11 +13,23 @@ export default Controller.extend(ModalFunctionality, {
errorMessage: null, errorMessage: null,
onShow() { onShow() {
let securityKeyName;
if (this.capabilities.isIOS && !this.capabilities.isIpadOS) {
securityKeyName = I18n.t(
"user.second_factor.security_key.iphone_default_name"
);
} else if (this.capabilities.isAndroid) {
securityKeyName = I18n.t(
"user.second_factor.security_key.android_default_name"
);
} else {
securityKeyName = I18n.t("user.second_factor.security_key.default_name");
}
// clear properties every time because the controller is a singleton // clear properties every time because the controller is a singleton
this.setProperties({ this.setProperties({
errorMessage: null, errorMessage: null,
loading: true, loading: true,
securityKeyName: I18n.t("user.second_factor.security_key.default_name"), securityKeyName,
webauthnUnsupported: !isWebauthnSupported(), webauthnUnsupported: !isWebauthnSupported(),
}); });

14
config/locales/client.en.yml
View File

@ -1393,7 +1393,7 @@ en:
edit_title: "Edit Authenticator" edit_title: "Edit Authenticator"
edit_description: "Authenticator Name" edit_description: "Authenticator Name"
enable_security_key_description: | enable_security_key_description: |
When you have your <a href="https://www.google.com/search?q=hardware+security+key" target="_blank">hardware security key</a> prepared, press the Register button below. When you have your <a href="https://www.google.com/search?q=hardware+security+key" target="_blank">hardware security key</a> or compatible mobile device prepared, press the Register button below.
totp: totp:
title: "Token-Based Authenticators" title: "Token-Based Authenticators"
add: "Add Authenticator" add: "Add Authenticator"
@ -1401,14 +1401,16 @@ en:
name_and_code_required_error: "You must provide a name and the code from your authenticator app." name_and_code_required_error: "You must provide a name and the code from your authenticator app."
security_key: security_key:
register: "Register" register: "Register"
title: "Security Keys" title: "Physical Security Keys"
add: "Add Security Key" add: "Add Physical Security Key"
default_name: "Main Security Key" default_name: "Main Security Key"
iphone_default_name: "iPhone"
android_default_name: "Android"
not_allowed_error: "The security key registration process either timed out or was cancelled." not_allowed_error: "The security key registration process either timed out or was cancelled."
already_added_error: "You have already registered this security key. You don’t have to register it again." already_added_error: "You have already registered this security key. You don’t have to register it again."
edit: "Edit Security Key" edit: "Edit Physical Security Key"
save: "Save" save: "Save"
edit_description: "Security Key Name" edit_description: "Physical Security Key Name"
name_required_error: "You must provide a name for your security key." name_required_error: "You must provide a name for your security key."
change_about: change_about:
@ -2008,7 +2010,7 @@ en:
second_factor_backup_title: "Two-Factor Backup" second_factor_backup_title: "Two-Factor Backup"
second_factor_backup_description: "Please enter one of your backup codes:" second_factor_backup_description: "Please enter one of your backup codes:"
second_factor: "Log in using Authenticator app" second_factor: "Log in using Authenticator app"
security_key_description: "When you have your physical security key prepared press the Authenticate with Security Key button below." security_key_description: "When you have your physical security key or compatible mobile device prepared press the Authenticate with Security Key button below."
security_key_alternative: "Try another way" security_key_alternative: "Try another way"
security_key_authenticate: "Authenticate with Security Key" security_key_authenticate: "Authenticate with Security Key"
security_key_not_allowed_error: "The security key authentication process either timed out or was cancelled." security_key_not_allowed_error: "The security key authentication process either timed out or was cancelled."