IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-28 19:53:53 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Use 127.0.0.1 instead of localhost as Capybara's server host (#27215)

Browse Source 
We are seeing a weird resolution error on Github actions with the
following backtrace:

```
Failure/Error:
  visit File.join(
          GlobalSetting.relative_url_root || "",
          "/session/#{user.encoded_username}/become.json?redirect=false",
        )

Socket::ResolutionError:
  getaddrinfo: Temporary failure in name resolution

```

Switch to use `127.0.0.1` instead of forcing a name resolution.
This commit is contained in:
Alan Guo Xiang Tan 2024-05-28 09:47:22 +08:00 committed by GitHub
parent b9984d9c64
commit 998b50fdf4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spec/rails_helper.rb
View File

@ -315,7 +315,7 @@ RSpec.configure do |config|
Capybara.w3c_click_offset = false
Capybara.configure do |capybara_config|
capybara_config.server_host = ENV["CAPYBARA_SERVER_HOST"].presence || "localhost"
capybara_config.server_host = ENV["CAPYBARA_SERVER_HOST"].presence || "127.0.0.1"
capybara_config.server_port =
(ENV["CAPYBARA_SERVER_PORT"].presence || "31_337").to_i + ENV["TEST_ENV_NUMBER"].to_i

5
spec/system/email_change_spec.rb
View File

@ -67,6 +67,9 @@ describe "Changing email", type: :system do
end
it "works when user has webauthn 2fa" do
@original_host = Capybara.server_host
SiteSetting.force_hostname = Capybara.server_host = "localhost"
# enforced 2FA flow needs a user created > 5 minutes ago
user.created_at = 6.minutes.ago
user.save!
@ -74,6 +77,7 @@ describe "Changing email", type: :system do
sign_in user
DiscourseWebauthn.stubs(:origin).returns(current_host + ":" + Capybara.server_port.to_s)
options =
::Selenium::WebDriver::VirtualAuthenticatorOptions.new(
user_verification: true,
@ -103,6 +107,7 @@ describe "Changing email", type: :system do
expect(user_preferences_page).to have_primary_email(new_email)
ensure
authenticator.remove!
SiteSetting.force_hostname = Capybara.server_host = @original_host
end
it "does not require login to verify" do

5
spec/system/user_page/user_preferences_security_spec.rb
View File

@ -8,6 +8,9 @@ describe "User preferences | Security", type: :system do
let(:user_menu) { PageObjects::Components::UserMenu.new }
before do
@original_host = Capybara.server_host
SiteSetting.force_hostname = Capybara.server_host = "localhost"
user.activate
# testing the enforced 2FA flow requires a user that was created > 5 minutes ago
user.created_at = 6.minutes.ago
@ -18,6 +21,8 @@ describe "User preferences | Security", type: :system do
DiscourseWebauthn.stubs(:origin).returns(current_host + ":" + Capybara.server_port.to_s)
end
after { SiteSetting.force_hostname = Capybara.server_host = @original_host }
shared_examples "security keys" do
it "adds a 2FA security key and logs in with it" do
options = ::Selenium::WebDriver::VirtualAuthenticatorOptions.new